Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String and string array fixes #419

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

String and string array fixes #419

wants to merge 5 commits into from

Conversation

RobertoRoos
Copy link
Contributor

@RobertoRoos RobertoRoos commented Sep 13, 2024 •
edited
Loading

Trying to improve string handling to solve some of the open issues.

Frankly I'm a bit lost what the issues are exactly, I'm trying to go through them slowly. EDIT: Okay, I think this is about it for now. I think this resolves all string issues?

Resolves:

Should resolve (but I haven't reproduced the issue before):

Obsoletes other PRs:

@coveralls
Copy link

coveralls commented Sep 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10849949250

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 95.0%
Totals Coverage Status
Change from base Build 10633721828: 0.05%
Covered Lines: 1729
Relevant Lines: 1820
💛 - Coveralls

RobertoRoos
RobertoRoos commented Sep 13, 2024
View reviewed changes
pyads/pyads_ex.py Outdated Show resolved Hide resolved
@RobertoRoos RobertoRoos mentioned this pull request Sep 13, 2024
Open
@RobertoRoos RobertoRoos marked this pull request as ready for review September 13, 2024 13:09
@RobertoRoos RobertoRoos changed the title String array fixes String and string array fixes Sep 13, 2024
@RobertoRoos RobertoRoos mentioned this pull request Sep 13, 2024
Open
@RobertoRoos
Copy link
Contributor Author

Okay, I think I'm done. @chrisbeardy whadda think? @stlehmann maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertoRoos @coveralls